Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping k8s APIs to v0.32.0. #963

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Conversation

ybettan
Copy link
Contributor

@ybettan ybettan commented Jan 1, 2025

@k8s-ci-robot
Copy link
Contributor

@ybettan: GitHub didn't allow me to request PR reviews from the following users: TomerNewman.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

The apimachinery library require go1.23.0 so go was bumped as well in this PR.

In addition, we need a golangci-lint version that was built with go1.23, therefore, it was bumped as well.


/assign @yevgeny-shnaidman
/cc @TomerNewman

This will hopefully fix the following failing PRs:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ybettan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 1, 2025
Copy link

netlify bot commented Jan 1, 2025

Deploy Preview for kubernetes-sigs-kmm ready!

Name Link
🔨 Latest commit 7984672
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/67753f6325a1190008447e93
😎 Deploy Preview https://deploy-preview-963--kubernetes-sigs-kmm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.68%. Comparing base (fa23a9b) to head (7984672).
Report is 165 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #963      +/-   ##
==========================================
- Coverage   79.09%   72.68%   -6.42%     
==========================================
  Files          51       65      +14     
  Lines        5109     5762     +653     
==========================================
+ Hits         4041     4188     +147     
- Misses        882     1395     +513     
+ Partials      186      179       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ybettan
Copy link
Contributor Author

ybettan commented Jan 1, 2025

/retest

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 1, 2025
@ybettan
Copy link
Contributor Author

ybettan commented Jan 1, 2025

/hold

Go will be bump in a separate PR.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 1, 2025
@ybettan
Copy link
Contributor Author

ybettan commented Jan 1, 2025

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 1, 2025
@yevgeny-shnaidman
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 1, 2025
@k8s-ci-robot k8s-ci-robot merged commit 31a6af2 into kubernetes-sigs:main Jan 1, 2025
22 checks passed
@ybettan ybettan deleted the pull-960 branch January 1, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants