-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding an enhancement for checking image existence using the container-runtime. #915
Conversation
@ybettan: GitHub didn't allow me to request PR reviews from the following users: TomerNewman. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ybettan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #915 +/- ##
==========================================
- Coverage 79.09% 72.62% -6.48%
==========================================
Files 51 65 +14
Lines 5109 4493 -616
==========================================
- Hits 4041 3263 -778
- Misses 882 1045 +163
+ Partials 186 185 -1 ☔ View full report in Codecov by Sentry. |
There is one more scenario that we need to handle:
We might consider adding some counter to the MIC spec , so that Module NMC might update it and thus trigger reconciliation. |
b3f5ac8
to
c90366d
Compare
…r-runtime. Signed-off-by: Yoni Bettan <[email protected]>
/lgtm |
/cc @yevgeny-shnaidman @mresvanis @TomerNewman