Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support bundle collection #595

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

qbarrand
Copy link
Contributor

@qbarrand qbarrand commented Oct 6, 2023

Add common labels to worker, build and signing pods so that their logs are collected in the support bundle.

Fixes #479

/cc @yevgeny-shnaidman @ybettan

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot requested a review from ybettan October 6, 2023 10:00
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qbarrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 6, 2023
@netlify
Copy link

netlify bot commented Oct 6, 2023

Deploy Preview for kubernetes-sigs-kmm ready!

Name Link
🔨 Latest commit e673af8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/6525127ff98fb700073fb20a
😎 Deploy Preview https://deploy-preview-595--kubernetes-sigs-kmm.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 6, 2023
@qbarrand qbarrand marked this pull request as ready for review October 6, 2023 10:38
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2023
Add common labels to worker, build and signing pods so that their logs
are collected in the support bundle.
@qbarrand qbarrand force-pushed the update-support-bundle branch from 364cc97 to e673af8 Compare October 10, 2023 08:59
@yevgeny-shnaidman
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3f05a76 into kubernetes-sigs:main Oct 10, 2023
12 checks passed
qbarrand added a commit to qbarrand/kernel-module-management that referenced this pull request Nov 8, 2023
Do not run make bundle in ci/prow/check-api-changes since we do not
version bundles.

Upstream-Commit: 8a657e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the support bundle spec
3 participants