Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix security warnings in client go code #743

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kannon92
Copy link
Contributor

@kannon92 kannon92 commented Jan 6, 2025

What type of PR is this?

Update net to 0.33.0

What this PR does / why we need it:

Security scanners are unhappy with net 0.22.0. Upgrading these dependencies satisfy the scanners.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This has no real impact but we have updated net throughout this repo so we might as well upgrade here too.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kannon92
Once this PR has been reviewed and has the lgtm label, please assign moficodes for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 6, 2025
Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for kubernetes-sigs-jobset ready!

Name Link
🔨 Latest commit c5598fd
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/677c1baa3e9eb3000844f283
😎 Deploy Preview https://deploy-preview-743--kubernetes-sigs-jobset.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kannon92
Copy link
Contributor Author

kannon92 commented Jan 6, 2025

/assign @moficodes

@ahg-g
Copy link
Contributor

ahg-g commented Jan 6, 2025

@kannon92 Can we run the scanners as a presubmit?

@kannon92
Copy link
Contributor Author

kannon92 commented Jan 7, 2025

@kannon92 Can we run the scanners as a presubmit?

Im not sure how GitHub does it. In my Openshift fork (also private works) I enabled the security setting that does scans of security issues. I can generate PRs from that and I’ve been opening them up on the upstream repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants