Replace comment that's no longer relevant #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
jingyuanliang
force-pushed
the
patch-6
branch
2 times, most recently
from
14f7584 to
ae00d80
Compare
jingyuanliang
changed the title
I believe the original issue occurred because the whole (after "-m") " comment --comment ..." string was parsed as the module name (in place of "comment"). It's not possible to put unparsed string in the args, because it doesn't go through a shell. Also removed the unnecessary quote; I think it was there because we assumed it's passing through the shell (so that words get split).
jingyuanliang
force-pushed
the
patch-6
branch
from
ae00d80 to
78062e5
Compare
MrHohn
approved these changes
Feb 14, 2025
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingyuanliang, MrHohn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the original issue occurred because the whole (after "-m")
" comment --comment ..." string was parsed as the module name (in place
of "comment"). It's not possible to put unparsed string in the args,
because it doesn't go through a shell.
Also removed the unnecessary quote; I think it was there because we
assumed it's passing through the shell (so that words get split).
/assign @MrHohn @mtaufen