Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/onsi/ginkgo/v2 from 2.22.0 to 2.22.2 #138

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 30, 2024

Bumps github.com/onsi/ginkgo/v2 from 2.22.0 to 2.22.2.

Release notes

Sourced from github.com/onsi/ginkgo/v2's releases.

v2.22.2

What's Changed

Full Changelog: onsi/ginkgo@v2.22.1...v2.22.2

v2.22.1

2.22.1

Fixes

Fix CSV encoding

  • Update tests [aab3da6]
  • Properly encode CSV rows [c09df39]
  • Add test case for proper csv escaping [96a80fc]
  • Add meta-test [43dad69]

Maintenance

  • ensure *.test files are gitignored so we don't accidentally commit compiled tests again [c88c634]
  • remove golang.org/x/net/context in favour of stdlib context [4df44bf]
Changelog

Sourced from github.com/onsi/ginkgo/v2's changelog.

2.22.2

Maintenance

  • Bump github.com/onsi/gomega from 1.36.1 to 1.36.2 (#1499) [cc553ce]
  • Bump golang.org/x/crypto (#1498) [2170370]
  • Bump golang.org/x/net from 0.32.0 to 0.33.0 (#1496) [a96c44f]

2.22.1

Fixes

Fix CSV encoding

  • Update tests [aab3da6]
  • Properly encode CSV rows [c09df39]
  • Add test case for proper csv escaping [96a80fc]
  • Add meta-test [43dad69]

Maintenance

  • ensure *.test files are gitignored so we don't accidentally commit compiled tests again [c88c634]
  • remove golang.org/x/net/context in favour of stdlib context [4df44bf]
Commits
  • f65e80b v2.22.2
  • cc553ce Bump github.com/onsi/gomega from 1.36.1 to 1.36.2 (#1499)
  • 2170370 Bump golang.org/x/crypto (#1498)
  • a96c44f Bump golang.org/x/net from 0.32.0 to 0.33.0 (#1496)
  • a0190b7 v2.22.1
  • 4df44bf remove golang.org/x/net/context in favour of stdlib context
  • c88c634 ensure *.test files are gitignored so we don't accidentally commit compiled t...
  • aab3da6 Update tests
  • c09df39 Properly encode CSV rows
  • 96a80fc Add test case for proper csv escaping
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added area/dependency Issues or PRs related to dependency changes ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. labels Dec 30, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 30, 2024
@dependabot dependabot bot requested a review from liu-cong December 30, 2024 22:03
@k8s-ci-robot k8s-ci-robot requested a review from kfswain December 30, 2024 22:03
@dependabot dependabot bot requested a review from robscott December 30, 2024 22:03
@k8s-ci-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 30, 2024
@ahg-g
Copy link
Contributor

ahg-g commented Jan 1, 2025

sent kubernetes/test-infra#34055 to address the image push issue

@kfswain
Copy link
Collaborator

kfswain commented Jan 6, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 6, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Jan 6, 2025

/retest

@ahg-g
Copy link
Contributor

ahg-g commented Jan 6, 2025

/retest all

@k8s-ci-robot
Copy link
Contributor

@ahg-g: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test pull-gateway-api-inference-extension-test-unit-main
/test pull-gateway-api-inference-extension-verify-main

Use /test all to run all jobs.

In response to this:

/retest all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahg-g
Copy link
Contributor

ahg-g commented Jan 6, 2025

/test all

@BenTheElder
Copy link
Member

/retest

@BenTheElder
Copy link
Member

/test

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test pull-gateway-api-inference-extension-test-unit-main
/test pull-gateway-api-inference-extension-verify-main

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BenTheElder
Copy link
Member

BenTheElder commented Jan 6, 2025

ah, you can't rerun postsubmits, they're triggered by pushes only. (they're only supposed to run after merge, but the way this is implemented in prow is listening to github push events to the main repo, which dependabot may have confused)

/skip

@BenTheElder
Copy link
Member

/override post-inference-extension-push-images

@BenTheElder
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 6, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@BenTheElder
Copy link
Member

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Jan 6, 2025
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BenTheElder
Copy link
Member

close + reopen doesn't appear to clear statuses on the github side these days, a repo admin will have to /override post-inference-extension-push-images

I believe @ahg-g already configured the postsubmit to not trigger on dependabot pushes in the future.

@SergeyKanzhelev
Copy link
Member

/override

@SergeyKanzhelev
Copy link
Member

/override post-inference-extension-push-images

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.22.0 to 2.22.2.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.22.0...v2.22.2)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/onsi/ginkgo/v2-2.22.2 branch from 971e547 to 7a98235 Compare January 6, 2025 22:45
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2025
@kfswain
Copy link
Collaborator

kfswain commented Jan 6, 2025

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot[bot], kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 370e841 into main Jan 6, 2025
3 of 4 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/onsi/ginkgo/v2-2.22.2 branch January 6, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants