Skip to content

Commit

Permalink
fix: re-add api-approved.kubernetes.io annotation
Browse files Browse the repository at this point in the history
  • Loading branch information
morremeyer committed May 21, 2024
1 parent 2dc0821 commit b3dd3b1
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
6 changes: 1 addition & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,7 @@ controller-gen:
ifeq (, $(shell which controller-gen))
@{ \
set -e ;\
CONTROLLER_GEN_TMP_DIR=$$(mktemp -d) ;\
cd $$CONTROLLER_GEN_TMP_DIR ;\
go mod init tmp ;\
go get sigs.k8s.io/controller-tools/cmd/[email protected] ;\
rm -rf $$CONTROLLER_GEN_TMP_DIR ;\
go install sigs.k8s.io/controller-tools/cmd/[email protected] ;\
}
CONTROLLER_GEN=$(GOBIN)/controller-gen
else
Expand Down
3 changes: 2 additions & 1 deletion docs/contributing/crd-source/crd-manifest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.14.0
api-approved.kubernetes.io: https://github.com/kubernetes-sigs/external-dns/pull/2007
controller-gen.kubebuilder.io/version: v0.15.0
name: dnsendpoints.externaldns.k8s.io
spec:
group: externaldns.k8s.io
Expand Down
1 change: 1 addition & 0 deletions endpoint/endpoint.go
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,7 @@ type DNSEndpointStatus struct {
// +kubebuilder:resource:path=dnsendpoints
// +kubebuilder:object:root=true
// +kubebuilder:subresource:status
// +kubebuilder:metadata:annotations="api-approved.kubernetes.io=https://github.com/kubernetes-sigs/external-dns/pull/2007"
// +versionName=v1alpha1

type DNSEndpoint struct {
Expand Down

0 comments on commit b3dd3b1

Please sign in to comment.