-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add containers test #1194
Add containers test #1194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this, @bitoku! 🙏
There seems no CI for crictl so I added them as well. |
sorry for the late reaction. |
@SergeyKanzhelev PTAL again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I'm sorry for bothering you many times. https://github.com/kubernetes-sigs/cri-tools/actions/runs/6874923452/job/18697587316?pr=1194 |
I don't get why we're getting an exit code 1 for all successful tests 🤔 But ginkgo is indicating that the suite failed. |
Couple options to debug - increase the ginkgo log level and try removing the |
Signed-off-by: Ayato Tokubi <[email protected]>
Signed-off-by: Ayato Tokubi <[email protected]>
Signed-off-by: Ayato Tokubi <[email protected]>
After some research I found the reason why it failed. First of all, the reason it didn't happen in my local env was that I didn't rebase it onto upstream/main. After rebasing it, I was able to reproduce it. And the CI failed because ginkgo somehow runs
I tested in my local and my forked repo, and it worked so I believe it works this time... |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bitoku, saschagrunert, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR adds unit tests to crictl (a part of container.go).
This also adds stretchr/testify and go-test/deep library.
Which issue(s) this PR fixes:
#1152
Special notes for your reviewer:
I wrote tests with default unittest framework.
Which do you prefer to use test framework, ginkgo or default?
Exisiting unittests in cmd/crictl is written with the default one.
Does this PR introduce a user-facing change?