add yaml lint and ci

.github/workflows/validate-yaml-manifests.yaml

@@ -0,0 +1,27 @@
+name: Lint
+
+# Trigger the workflow on push and pull request
+on: [push, pull_request]
+
+jobs:
+  yamllint:
+    name: Run yamllint
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up Go
+        uses: actions/setup-go@v4
+        with:
+          go-version: '1.22'
+
+      - name: Calculate go version
+        run: make go-version
+
+      - name: Install yamllint
+        run: make install-yamllint
+
+      - name: Run yamllint
+        run: make lint-yaml

.yamllint

@@ -0,0 +1,43 @@
+extends: default
+
+ignore:
+  - config       # Skip autogenerated config dir from liniting
+
+rules:
+  # Rules to control the number of spaces around operators
+  braces:
+    min-spaces-inside: 0    # No spaces required inside braces
+    max-spaces-inside: 1    # Maximum one space inside braces
+  brackets:
+    min-spaces-inside: 0
+    max-spaces-inside: 1
+  colons:
+    max-spaces-before: 0
+    max-spaces-after: 1
+  commas:
+    max-spaces-before: 0
+    max-spaces-after: 1
+  hyphens:
+    max-spaces-after: 1
+
+  # Rules to control indentation
+  indentation:
+    spaces: consistent              # Spaces should be consistently used for indentation
+    indent-sequences: whatever      # Either indenting or not indenting individual block sequences is OK
+  comments-indentation: enable      # Comments should be indented the same as the content
+
+  # Rules to control lines
+  line-length:
+    max: 150                                       # Maximum 150 characters per line
+    allow-non-breakable-words: true                # Allow long words without breaks
+    allow-non-breakable-inline-mappings: true      # Allow long inline mappings without breaks
+  empty-lines:
+    max: 2                                         # Maximum two consecutive empty lines allowed
+  trailing-spaces: enable                          # Ensure no trailing spaces at the end of lines
+
+  # Other rules
+  comments:
+    min-spaces-from-content: 1                        # At least one space required between content and comment
+  key-duplicates: enable                              # Ensure no duplicate keys in mappings
+  truthy:
+    allowed-values: ['true', 'false', 'on', 'off']    # Allow only these values for boolean scalars

Makefile

@@ -546,6 +546,24 @@ else
 	echo "Versions are different across Makefiles. Please ensure to keep them uniform."
 endif
 
+
+.PHONY: install-yamllint
+install-yamllint: ## Install yamllint if not present
+	@which yamllint > /dev/null || (echo "Installing yamllint..." && go install github.com/wasilibs/go-yamllint/cmd/yamllint@latest)
+	@echo "yamllint installed"
+
+.PHONY: lint-yaml
+lint-yaml: ## Run yamllint
+	@echo "Running yamllint..."
+	@yamllint . || true
+	@echo "Linting Yaml files completed"
+
+.PHONY: lint-yaml-no-warnings
+lint-yaml-no-warnings: ## Run yamllint and won’t output warning level problems
+	@echo "Running yamllint and won't output warning level problems..."
+	@yamllint . --no-warnings || true
+	@echo "Linting Yaml files completed"
+
 ## --------------------------------------
 ## Cleanup / Verification
 ## --------------------------------------

templates/bases/vpc/kcp.yaml

@@ -26,14 +26,14 @@ spec:
     initConfiguration:
       nodeRegistration:
         criSocket: /var/run/containerd/containerd.sock
-        kubeletExtraArgs: 
+        kubeletExtraArgs:
           cloud-provider: external
           eviction-hard: 'nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%'
     joinConfiguration:
       discovery: {}
       nodeRegistration:
         criSocket: /var/run/containerd/containerd.sock
-        kubeletExtraArgs: 
+        kubeletExtraArgs:
           cloud-provider: external
           eviction-hard: 'nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%'
 ---

templates/cluster-template-powervs-clusterclass/cluster-with-kcp.yaml

@@ -53,12 +53,12 @@ spec:
             ref:
               apiVersion: bootstrap.cluster.x-k8s.io/v1beta1
               kind: KubeadmConfigTemplate
-              name:  "${IBMPOWERVS_CLUSTER_CLASS_NAME}-md-0"
+              name: "${IBMPOWERVS_CLUSTER_CLASS_NAME}-md-0"
           infrastructure:
             ref:
               apiVersion: infrastructure.cluster.x-k8s.io/v1beta2
               kind: IBMPowerVSMachineTemplate
-              name:  "${IBMPOWERVS_CLUSTER_CLASS_NAME}-worker-machinetemplate"
+              name: "${IBMPOWERVS_CLUSTER_CLASS_NAME}-worker-machinetemplate"
 ---
 apiVersion: infrastructure.cluster.x-k8s.io/v1beta2
 kind: IBMPowerVSClusterTemplate

templates/cluster-template-powervs/kcp.yaml

@@ -13,4 +13,3 @@ spec:
       nodeRegistration:
         kubeletExtraArgs:
           provider-id: ibmpowervs://${CLUSTER_NAME}/'{{ v1.local_hostname }}'
-

templates/cluster-template-vpc-clusterclass/cluster-with-kcp.yaml

@@ -104,13 +104,13 @@ spec:
         initConfiguration:
           nodeRegistration:
             criSocket: /var/run/containerd/containerd.sock
-            kubeletExtraArgs: 
+            kubeletExtraArgs:
               cloud-provider: external
               eviction-hard: 'nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%'
         joinConfiguration:
           discovery: {}
           nodeRegistration:
             criSocket: /var/run/containerd/containerd.sock
-            kubeletExtraArgs: 
+            kubeletExtraArgs:
               cloud-provider: external
               eviction-hard: 'nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%'

templates/cluster-template/cluster.yaml

@@ -5,4 +5,3 @@ metadata:
   namespace: "${NAMESPACE}"
   labels:
     ccm: external
-

templates/cluster-template/kcp.yaml

@@ -12,4 +12,3 @@ spec:
       apiServer:
         extraArgs:
           cloud-provider: external
-

test/e2e/data/cni/calico/calico.yaml

@@ -4229,7 +4229,7 @@ rules:
     resources:
       - endpointslices
     verbs:
-      - watch 
+      - watch
       - list
   - apiGroups: [""]
     resources: