-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: refine UT for gen-disk-skus-map_test #2787
Conversation
Hi @Zhupku. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
f6dee0b
to
726f791
Compare
/ok-to-test |
/retest |
@Zhupku: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
726f791
to
3b0a5c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, Zhupku The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This pull request introduces a new test scenario for generating disk SKU maps and includes a sample JSON file for testing purposes. The changes primarily focus on adding conditional logic to handle the test scenario and updating the test setup accordingly.
Key changes include:
Test Scenario Implementation:
pkg/tool/gen-disk-skus-map.go
: Added conditional logic to check for theTEST_SCENARIO
environment variable and use theskus-sample.json
file if set. This allows for a predefined set of SKUs to be used during testing.Test Setup:
pkg/tool/gen-disk-skus-map_test.go
: Updated the test setup to set theTEST_SCENARIO
environment variable and ensure it is unset after the test. This ensures that the test uses the sample SKU data.Sample Data:
pkg/tool/skus-sample.json
: Added a sample JSON file containing predefined SKU data to be used during the test scenario. This file includes various SKU attributes and capabilities.<!-- Thanks for sending a pull request! Here are some tips for you:https://github.com/kubernetes/community/blob/master/contributors/devel/sig-release/release.md#issue-kind-label
-->
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: