-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for additional disc_formats #374
Open
stephenmoloney
wants to merge
1
commit into
kubenow:master
Choose a base branch
from
stephenmoloney:fix/disc_format
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,332 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| function get_image_status() { | ||
| local image_name=$1 | ||
| local image_id | ||
| local image_details | ||
| image_id=$(get_image_id "${image_name}") | ||
| image_details="$(glance image-show "${image_id}")" | ||
|
|
||
| printf '%s' "${image_details}" | | ||
| grep -w "status" | | ||
| awk -F "|" '{print $3;}' | | ||
| tr -d '[:space:]' | ||
| } | ||
|
|
||
| function get_image_id() { | ||
| local image_name=$1 | ||
| local image_list | ||
| image_list="$(glance image-list)" | ||
|
|
||
| printf '%s' "${image_list}" | | ||
| grep -w "${image_name}" | | ||
| awk -F "|" '{print $2;}' | | ||
| tr -d '[:space:]' | ||
| } | ||
|
|
||
| function get_server_image_disc_format() { | ||
| local image_id=$1 | ||
| local image_details | ||
| image_details="$(glance image-show "${image_id}")" | ||
|
|
||
| printf '%s' "${image_details}" | | ||
| grep -w "disk_format" | | ||
| awk -F "|" '{print $3;}' | | ||
| tr -d '[:space:]' | ||
| } | ||
|
|
||
| function image_exists() { | ||
| local image_name=$1 | ||
| local image_id | ||
| image_id=$(get_image_id "${image_name}") | ||
|
|
||
| if [[ "${image_id}" != "" ]]; then | ||
| echo "true" | ||
| else | ||
| echo "false" | ||
| fi | ||
| } | ||
|
|
||
| function get_server_uploaded_image_checksum() { | ||
| local image_id=$1 | ||
| local image_details | ||
| image_details="$(glance image-show "${image_id}")" | ||
|
|
||
| printf '%s' "${image_details}" | | ||
| grep -w "checksum" | | ||
| awk -F "|" '{print $3;}' | | ||
| tr -d '[:space:]' | ||
| } | ||
|
|
||
| function is_image_downloaded_already() { | ||
| local download_filepath=$1 | ||
|
|
||
| if [[ -e ${download_filepath} ]]; then | ||
| echo "true" | ||
| else | ||
| echo "false" | ||
| fi | ||
| } | ||
|
|
||
| function is_uploaded_disc_format_as_expected() { | ||
| local image_name=$1 | ||
| local glance_disc_format=$2 | ||
| local image_id | ||
| image_id=$(get_image_id "${image_name}") | ||
| server_disc_format=$(get_server_image_disc_format "${image_id}") | ||
|
|
||
| if [[ "${server_disc_format}" == "${glance_disc_format}" ]]; then | ||
| echo "true" | ||
| else | ||
| echo "false" | ||
| fi | ||
| } | ||
|
|
||
| function is_image_already_uploaded() { | ||
| local image_name=$1 | ||
| local glance_disc_format=$2 | ||
| local image_id | ||
| image_id=$(get_image_id "${image_name}") | ||
|
|
||
| if [[ "${image_id}" == "" ]]; then | ||
| echo "false" | ||
| else | ||
| echo "true" | ||
| fi | ||
| } | ||
|
|
||
| function wait_for_image_activation() { | ||
| local image_name=$1; | ||
| local wait_time | ||
| local max_wait | ||
| local sleep_time | ||
| local status | ||
| wait_time=0 | ||
| max_wait=300 | ||
| sleep_time=3 | ||
| status="nothing" | ||
|
|
||
| # Wait until image status is "active" | ||
| while [[ "${status}" != "active" && ${wait_time} -lt ${max_wait} ]]; do | ||
| # allow for image to be ready | ||
| sleep ${sleep_time} | ||
| wait_time=$((wait_time + sleep_time)) | ||
| status=$(get_image_status "${image_name}") | ||
| done | ||
|
|
||
| echo "${status}" | ||
| } | ||
|
|
||
| function get_host_uploaded_image_checksum() { | ||
| local image_name=$1 | ||
| local glance_disc_format=$2 | ||
| local image_url=$3 | ||
| local upload_filepath="/tmp/${image_name}.${glance_disc_format}" | ||
| local checksum | ||
|
|
||
| if [[ "${glance_disc_format}" == "qcow2" ]]; then | ||
| # Download the checksum of the qcow2 image from Kubenow servers | ||
| curl "${image_url}/${image_name}.md5" \ | ||
| -o "${upload_filepath}.md5" \ | ||
| --connect-timeout 30 \ | ||
| --max-time 30 | ||
|
|
||
| checksum=$(cut -f1 -d ' ' "${upload_filepath}.md5") | ||
| else | ||
| # Generate the md5 from the local file which is present on the local disc | ||
| checksum=$(md5sum "${upload_filepath}" | awk '{print $1}') | ||
| fi | ||
|
|
||
| echo "${checksum}" | ||
| } | ||
|
|
||
| function verify_uploaded_image() { | ||
| local image_name=$1 | ||
| local glance_disc_format=$2 | ||
| local image_url=$3 | ||
| local image_list | ||
| local image_id | ||
| local image_details | ||
| local server_checksum | ||
| local host_checksum | ||
| image_id=$(get_image_id "${image_name}") | ||
| server_checksum=$(get_server_uploaded_image_checksum "${image_id}") | ||
|
|
||
| if [[ ${#server_checksum} != 32 ]]; then | ||
| echo "No valid server_checksum field on server, skipping checksum verification step" | ||
| else | ||
| host_checksum=$(get_host_uploaded_image_checksum "${image_name}" "${glance_disc_format}" "${image_url}") | ||
|
|
||
| if [ "${host_checksum}" != "${server_checksum}" ]; then | ||
| echo >&2 "Server checksum: ${server_checksum}" | ||
| echo >&2 "Expected checksum: ${host_checksum}" | ||
| echo >&2 "The server image checksum does not match expectations" | ||
| echo >&2 "Something might have failed on file transfer." | ||
| echo >&2 "Please delete image ${image_name} from Openstack and try again." | ||
| exit 1 | ||
| else | ||
| echo "Uploaded image checksum is OK" | ||
| fi | ||
| fi | ||
| } | ||
|
|
||
| function upload_image() { | ||
| local image_name=$1 | ||
| local glance_disc_format=$2 | ||
| local image_url=$3 | ||
| local upload_filepath="/tmp/${image_name}.${glance_disc_format}" | ||
| local min_disc=5 | ||
| local image_size | ||
| local image_size_number | ||
| image_size=$(du -sh --block-size=G --apparent-size "${upload_filepath}" | awk '{print $1}') | ||
| image_size_number=${image_size::-1} | ||
|
|
||
| if [[ "${glance_disc_format}" == "raw" ]]; then | ||
| min_disc=${image_size_number}; | ||
| fi | ||
|
|
||
| # Upload image | ||
| echo "Starting upload of ${image_name}" | ||
| echo -e "\n" | ||
| echo "image source: ${upload_filepath}" | ||
| echo "image name: ${image_name}" | ||
| echo "image format: ${glance_disc_format}" | ||
| echo "image size: ${image_size_number} GB" | ||
| echo -e "\n" | ||
| glance image-create \ | ||
| --file "${upload_filepath}" \ | ||
| --disk-format "${glance_disc_format}" \ | ||
| --min-disk "${min_disc}" \ | ||
| --container-format bare \ | ||
| --name "${image_name}" \ | ||
| --progress | ||
|
|
||
| echo "Verifying the uploaded image" | ||
| echo -e "\n" | ||
|
|
||
| post_image_upload_checks "${image_name}" "${glance_disc_format}" "${image_url}" | ||
| } | ||
|
|
||
| function verify_downloaded_image() { | ||
| local download_filename=$1 | ||
| local download_url=$2 | ||
| local download_filepath="/tmp/${download_filename}" | ||
|
|
||
| echo "Downloading ${download_url}/${download_filename}.md5 file" | ||
| curl "${download_url}/${download_filename}.md5" \ | ||
| -o "${download_filepath}.md5" \ | ||
| --connect-timeout 30 \ | ||
| --max-time 30 | ||
|
|
||
| # Verify md5sum of downloaded file | ||
| echo "Checking md5 sum" | ||
| md5result=$( | ||
| cd /tmp || exit; | ||
| md5sum -c "${download_filename}.md5" | ||
| ) | ||
| if [[ "${md5result}" != *": OK"* ]]; then | ||
| echo >&2 "Wrong checksum of downloaded image." | ||
| echo >&2 "Something might have failed on file transfer." | ||
| echo >&2 "Please try again." | ||
| exit 1 | ||
| else | ||
| echo "Checksum of downloaded image OK" | ||
| fi | ||
| } | ||
|
|
||
| function post_image_upload_checks() { | ||
| local image_name=$1 | ||
| local glance_disc_format=$2 | ||
| local image_url=$3 | ||
| local is_uploaded_disc_format_as_expected | ||
| local image_id | ||
| image_id=$(get_image_id "${image_name}") | ||
| server_image_disc_format=$(get_server_image_disc_format "${image_id}") | ||
| is_uploaded_disc_format_as_expected=$(is_uploaded_disc_format_as_expected "${image_name}" "${glance_disc_format}") | ||
|
|
||
| # Verify the server image is in the expected glance_disc_format | ||
| if [[ "${is_uploaded_disc_format_as_expected}" == "false" ]]; then | ||
| echo >&2 "Host image disc format: ${glance_disc_format}" | ||
| echo >&2 "Server image disc format: ${server_image_disc_format}" | ||
| echo >&2 "${image_name} disc format on the server is not as expected" | ||
| echo >&2 "Delete the server image and retry the kn init process" | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Verify uploaded image checksums | ||
| verify_uploaded_image "${image_name}" "${glance_disc_format}" "${image_url}" | ||
| } | ||
|
|
||
| function download_image() { | ||
| local download_filename=$1 | ||
| local download_url=$2 | ||
| local download_filepath="/tmp/${download_filename}" | ||
|
|
||
| echo "Downloading image to local /tmp/" | ||
| echo -e "\n" | ||
| curl "${download_url}/${download_filename}" \ | ||
| -o "${download_filepath}" \ | ||
| --connect-timeout 30 \ | ||
| --max-time 1800 | ||
|
|
||
| echo "Verifying the md5 checksum of the downloaded image" | ||
| echo -e "\n" | ||
| verify_downloaded_image "${download_filename}" "${download_url}" | ||
| } | ||
|
|
||
| function maybe_download_image(){ | ||
| local image_name=$1 | ||
| local glance_disc_format=$2 | ||
| local download_url=$3 | ||
| local download_filename="${image_name}.qcow2" | ||
| local download_filepath="/tmp/${image_name}.qcow2" | ||
| local is_image_downloaded_already | ||
| is_image_downloaded_already=$(is_image_downloaded_already "${download_filepath}") | ||
|
|
||
| if [[ "${is_image_downloaded_already}" == "false" ]]; then | ||
| download_image "${download_filename}" "${download_url}" | ||
| else | ||
| echo "${download_filename} is already downloaded" | ||
| echo "Verifying the downloaded image checksum" | ||
| echo -e "\n" | ||
|
|
||
| verify_downloaded_image "${download_filename}" "${download_url}" | ||
| fi | ||
| } | ||
|
|
||
| function maybe_convert_image(){ | ||
| local image_name=$1 | ||
| local glance_disc_format=$2 | ||
| local download_url=$3 | ||
| local download_filename="${image_name}.qcow2" | ||
| local download_filepath="/tmp/${image_name}.qcow2" | ||
| local upload_filepath="/tmp/${image_name}.${glance_disc_format}" | ||
| local qemu_installed | ||
| local is_image_downloaded_already | ||
| is_image_downloaded_already=$(is_image_downloaded_already "${download_filepath}") | ||
| qemu_installed=$(which qemu-img) | ||
|
|
||
| if [[ ! -e ${upload_filepath} ]]; then | ||
| if [[ "${qemu_installed}" == "" ]]; then | ||
| echo >&2 "qemu-utils package is missing - image cannot be converted" | ||
| echo >&2 "Please ensure that qemu-img is available." | ||
| exit 1 | ||
| else | ||
| if [[ "${is_image_downloaded_already}" == "false" ]]; then | ||
| echo >&2 "No file found at ${download_filepath}" | ||
| echo >&2 "Please ensure image has been downloaded" | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "${download_filepath} has not yet been converted to the ${glance_disc_format} format" | ||
| echo "Starting the image conversion from qcow2 to ${glance_disc_format}..." | ||
| echo -e "\n" | ||
|
|
||
| qemu-img convert -q -f qcow2 -O "${glance_disc_format}" "${download_filepath}" "${upload_filepath}" | ||
|
|
||
| echo "${image_name}.qcow2 conversion to ${upload_filepath} complete" | ||
| fi | ||
| else | ||
| echo "${upload_filepath} already exists and so does not require conversion" | ||
| fi | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you check how much this affects the Docker image size?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure.. this is how it reads from
docker image ls