Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword "All Certified Kubernetes Distributions" to "Multiple" #3914

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thesuperzapper
Copy link
Member

@thesuperzapper thesuperzapper commented Oct 22, 2024

We are trying to reduce confusion for users who are trying to figure out which distributions support their Kubernetes clusters.

This PR makes the following changes:

  • Rewords "All Certified Kubernetes Distributions" to "Multiple"
    • I have only updated deployKF, if other distributions want, they can copy this in their own PRs.
    • Also adds a [list] reference, which links to that distribution's list of supported Kubernetes platforms.
  • Makes the [version matrix] and [release notes] references lowercase (makes it less busy on screen)

Old Screenshot

Screenshot 2024-12-17 at 09 59 38

New Screenshot

Screenshot 2024-12-17 at 09 59 19

Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@google-oss-prow google-oss-prow bot requested review from alfsuse and knkski October 22, 2024 19:26
@thesuperzapper thesuperzapper changed the title Add "version notice" popouts to Packaged Distributions table Reword "All Certified Kubernetes Distributions" to "Multiple" Oct 23, 2024
@thesuperzapper thesuperzapper force-pushed the simplify-target-platforms branch 3 times, most recently from 5119c2f to ae37826 Compare October 29, 2024 19:25
@thesuperzapper thesuperzapper force-pushed the simplify-target-platforms branch from ae37826 to bae135a Compare October 30, 2024 19:32
@thesuperzapper thesuperzapper changed the title Reword "All Certified Kubernetes Distributions" to "Multiple" Update deployKF "Target Platform" to "Multiple" Oct 30, 2024
@thesuperzapper thesuperzapper force-pushed the simplify-target-platforms branch from bae135a to dc36fec Compare November 12, 2024 16:10
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign 8bitmp3 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added size/S and removed size/L labels Nov 12, 2024
@thesuperzapper thesuperzapper marked this pull request as ready for review November 12, 2024 16:37
@jbottum
Copy link
Contributor

jbottum commented Nov 12, 2024

+1, I would like Canonical to weigh in before lgtm

@thesuperzapper
Copy link
Member Author

@kimwnasptd can you get confirmation from whoever at canonical can make the decision?

@andreeamun
Copy link

andreeamun commented Dec 16, 2024

Hello. It is alright for Canonical, even if I am worried that the list will change over time for different organisations, so it will be difficult to maintain it and keep it accurate.

@thesuperzapper thesuperzapper force-pushed the simplify-target-platforms branch from dc36fec to 6fa623f Compare December 17, 2024 17:58
@thesuperzapper
Copy link
Member Author

@jbottum as we now have confirmation from @andreeamun, can you please approve this PR?

@thesuperzapper thesuperzapper changed the title Update deployKF "Target Platform" to "Multiple" Update "Target Platform" to "Multiple" Dec 17, 2024
@thesuperzapper thesuperzapper changed the title Update "Target Platform" to "Multiple" Reword "All Certified Kubernetes Distributions" to "Multiple" Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants