Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor client body #1462

Merged
merged 4 commits into from
Apr 7, 2024
Merged

refactor client body #1462

merged 4 commits into from
Apr 7, 2024

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Apr 7, 2024

Refactors the response body.

@tottoto tottoto changed the title Refactor client body refactor client body Apr 7, 2024
Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 71.9%. Comparing base (5dce83b) to head (01936ba).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1462     +/-   ##
=======================================
- Coverage   72.1%   71.9%   -0.1%     
=======================================
  Files         78      78             
  Lines       6592    6571     -21     
=======================================
- Hits        4747    4721     -26     
- Misses      1845    1850      +5     
Files Coverage Δ
kube-client/src/client/body.rs 71.5% <44.5%> (-10.9%) ⬇️

@tottoto tottoto force-pushed the refactor-client-body branch from 01936ba to cf829c1 Compare April 7, 2024 10:16
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice. thank you!

@clux clux added this to the 0.91.0 milestone Apr 7, 2024
@clux clux added the changelog-exclude changelog excluded prs label Apr 7, 2024
@clux clux merged commit 2fb575c into kube-rs:main Apr 7, 2024
16 checks passed
@tottoto tottoto deleted the refactor-client-body branch April 7, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-exclude changelog excluded prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants