Fix minor new lints and better info on pod reflector memory usage #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caused a question and the figure is old and not necessarily super helpful. making it deliberately more vague and redirecting to actual graphs. Signed-off-by: clux <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1440 +/- ##
=====================================
Coverage 72.1% 72.1%
=====================================
Files 78 78
Lines 6594 6594
=====================================
Hits 4749 4749
Misses 1845 1845
|
Signed-off-by: clux <[email protected]>
nightkr
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reflector figure caused a question in discord, but the figure is old and probably not accurate anymore. have recent graphs in the 100-400MB range on https://kube.rs/controllers/optimization/#reflector-optimization with the same data as the doc string was written for so using that very vaguely and linking to the above doc.
also fixing minor new lint errors and doc issues before a release.