-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clippy suggestions and warning removal #1436
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clux <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1436 +/- ##
=====================================
Coverage 72.2% 72.2%
=====================================
Files 78 78
Lines 6546 6546
=====================================
Hits 4722 4722
Misses 1824 1824
|
they have done some questionable deprecations Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
clux
commented
Mar 22, 2024
it is for the same purpose so documenting it Signed-off-by: clux <[email protected]>
nightkr
approved these changes
Mar 22, 2024
Co-authored-by: Natalie Klestrup Röijezon <[email protected]> Signed-off-by: Eirik A <[email protected]>
Signed-off-by: clux <[email protected]>
nightkr
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes:
clone_from
rather than assigning cloneTo see what the warnings looked like an hour ago. Look at the files annotated in the previous PR: https://github.com/kube-rs/kube/pull/1435/files#file-kube-client-src-client-mod-rs-L10