Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspacify deps #1435

Merged
merged 4 commits into from
Mar 22, 2024
Merged

Workspacify deps #1435

merged 4 commits into from
Mar 22, 2024

Conversation

clux
Copy link
Member

@clux clux commented Mar 22, 2024

Simplify dependency management a bit by unifying dependency versions in workspace where it makes sense.

Basically ran autoinherit (via this tool) with some fixes (it broke the syntax slightly), and then moved examples/ only deps back into examples.

Feels like a good time to do these cleanups now with no major outstanding PRs that faff with deps.

@clux clux added this to the 0.89.0 milestone Mar 22, 2024
@clux clux added the changelog-exclude changelog excluded prs label Mar 22, 2024
@clux clux marked this pull request as ready for review March 22, 2024 15:41
@clux clux requested review from nightkr and mateiidavid March 22, 2024 15:41
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.2%. Comparing base (e9094ca) to head (fa7a90d).

❗ Current head fa7a90d differs from pull request most recent head cfe8658. Consider uploading reports for the commit cfe8658 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1435   +/-   ##
=====================================
  Coverage   72.2%   72.2%           
=====================================
  Files         78      78           
  Lines       6546    6546           
=====================================
  Hits        4722    4722           
  Misses      1824    1824           

Copy link
Member

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yess, love this.

One nitpick is that cargo add adds MYDEP.workspace = true rather than MYDEP = { workspace = true }. Semantically they should be equivalent, but the former looks neater IMO.

kube-core/Cargo.toml Outdated Show resolved Hide resolved
@clux
Copy link
Member Author

clux commented Mar 22, 2024

yeah, people had the same complaint in the reddit post. i'll do a commit changing it over.

ran a search and replace in my editor to convert this to the cargo add style now. it only helps where there are no other properties ofc, but still cleaner.

@clux clux merged commit 959986a into main Mar 22, 2024
17 checks passed
@clux clux deleted the workspacify-deps branch March 22, 2024 17:03
@clux clux linked an issue Mar 25, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-exclude changelog excluded prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring Version Dependencies
2 participants