-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workspacify deps #1435
Workspacify deps #1435
Conversation
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1435 +/- ##
=====================================
Coverage 72.2% 72.2%
=====================================
Files 78 78
Lines 6546 6546
=====================================
Hits 4722 4722
Misses 1824 1824 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yess, love this.
One nitpick is that cargo add
adds MYDEP.workspace = true
rather than MYDEP = { workspace = true }
. Semantically they should be equivalent, but the former looks neater IMO.
Signed-off-by: clux <[email protected]>
yeah, people had the same complaint in the reddit post. i'll do a commit changing it over. ran a search and replace in my editor to convert this to the cargo add style now. it only helps where there are no other properties ofc, but still cleaner. |
Simplify dependency management a bit by unifying dependency versions in workspace where it makes sense.
Basically ran
autoinherit
(via this tool) with some fixes (it broke the syntax slightly), and then moved examples/ only deps back into examples.Feels like a good time to do these cleanups now with no major outstanding PRs that faff with deps.