Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustls + rustls-pemfile upgrade #1418

Closed
wants to merge 2 commits into from

cherry-pick rustls upgrade work

8e9b9a1
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Closed

rustls + rustls-pemfile upgrade #1418

cherry-pick rustls upgrade work
8e9b9a1
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy failed Mar 5, 2024 in 0s

clippy

2 errors, 3 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 2
Warning 3
Note 0
Help 0

Versions

  • rustc 1.78.0-nightly (d18480b84 2024-03-04)
  • cargo 1.78.0-nightly (f772ec022 2024-03-01)
  • clippy 0.1.78 (d18480b 2024-03-04)

Annotations

Check warning on line 3 in kube-client/src/client/tls.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `hyper_rustls::ConfigBuilderExt`

warning: unused import: `hyper_rustls::ConfigBuilderExt`
 --> kube-client/src/client/tls.rs:3:9
  |
3 |     use hyper_rustls::ConfigBuilderExt;
  |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 55 in kube-client/src/client/tls.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no method named `with_native_roots` found for struct `rustls::ConfigBuilder` in the current scope

error[E0599]: no method named `with_native_roots` found for struct `rustls::ConfigBuilder` in the current scope
  --> kube-client/src/client/tls.rs:55:18
   |
54 | /             ClientConfig::builder()
55 | |                 .with_native_roots()
   | |                 -^^^^^^^^^^^^^^^^^ method not found in `ConfigBuilder<ClientConfig, WantsVerifier>`
   | |_________________|
   | 

Check failure on line 230 in kube-client/src/client/config_ext.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

mismatched types

error[E0308]: mismatched types
   --> kube-client/src/client/config_ext.rs:230:30
    |
230 |             .with_tls_config(rustls_config)
    |              --------------- ^^^^^^^^^^^^^ expected `ClientConfig`, found `rustls::ClientConfig`
    |              |
    |              arguments to this method are incorrect
    |
    = note: `rustls::ClientConfig` and `ClientConfig` have similar names, but are actually distinct types
note: `rustls::ClientConfig` is defined in crate `rustls`
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rustls-0.23.1/src/client/client_conn.rs:147:1
    |
147 | pub struct ClientConfig {
    | ^^^^^^^^^^^^^^^^^^^^^^^
note: `ClientConfig` is defined in crate `rustls`
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rustls-0.21.10/src/client/client_conn.rs:128:1
    |
128 | pub struct ClientConfig {
    | ^^^^^^^^^^^^^^^^^^^^^^^
    = note: perhaps two different versions of crate `rustls` are being used?
note: method defined here
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-rustls-0.24.2/src/connector/builder.rs:46:12
    |
46  |     pub fn with_tls_config(self, config: ClientConfig) -> ConnectorBuilder<WantsSchemes> {
    |            ^^^^^^^^^^^^^^^

Check warning on line 8 in kube-client/src/client/builder.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `kube_core::response::Status`

warning: unused import: `kube_core::response::Status`
 --> kube-client/src/client/builder.rs:8:9
  |
8 | pub use kube_core::response::Status;
  |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 4 in kube-client/src/discovery/apigroup.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused imports: `Scope`, `verbs`

warning: unused imports: `Scope`, `verbs`
 --> kube-client/src/discovery/apigroup.rs:4:32
  |
4 | pub use kube_core::discovery::{verbs, ApiCapabilities, ApiResource, Scope};
  |                                ^^^^^                                ^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default