Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the otel group with 4 updates and change builder functions #124

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Bump the otel group with 4 updates and change builder functions #124

merged 1 commit into from
Jan 1, 2025

Conversation

yeongjukang
Copy link
Contributor

@yeongjukang yeongjukang commented Dec 26, 2024 •
edited
Loading

Hi, thank you for building this.
This action of #114 seems broken so I updated libs and changed builder functions following this OTEL's official guide below.

Additionally, with_config and with_resource functions for trace configuration will become private soon.
May I replace it with with_resource?

@clux
Copy link
Member

clux commented Dec 27, 2024

Hey, thanks a lot for trying this!

It's currently failing ci (ci tests both default features and --all-features), but happy to accept an upgrade that compiles and works. I'll try to push the approve and run CI button as soon as possible.

Additionally, with_config and with_resource functions for trace configuration will become private soon.
May I replace it with with_resource?

Go for it 🙏

@yeongjukang
Copy link
Contributor Author

@clux
Sorry I am beginner to Rust so didn't understand toolchains and rules properly.
I will try to make things polished like deprecated OTEL ports at justfile.
Thank you for the review and please give me some more few days!

@yeongjukang
Bump the otel group with 4 updates and change builder functions
93074df 
Signed-off-by: Yeongju Kang <[email protected]>
Signed-off-by: Yeongju Kang <[email protected]>

added some new lines following linter
@yeongjukang
Copy link
Contributor Author

@clux
few changes added after first one

  • changed deprecated port number from 55680 to 4317 for local test
  • added docker-compose.yaml for local test and added run command at justfile
  • with_resource applied

clux
clux approved these changes Jan 1, 2025
View reviewed changes
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

I see it builds and passes CI so that's proof enough for me.

justfile
@@ -12,7 +12,8 @@ generate:

# run with opentelemetry
run-telemetry:
OPENTELEMETRY_ENDPOINT_URL=http://127.0.0.1:55680 RUST_LOG=info,kube=debug,controller=debug cargo run --features=telemetry
docker-compose up -d
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. i might end up taking this out as i've killed off docker-compose deps elsewhere in favor of k3d installs, but i'll at least merge it in now for git history.

@clux clux merged commit f5160dd into kube-rs:main Jan 1, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clux clux clux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yeongjukang @clux