Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support wechat notification #38

Merged
merged 2 commits into from
Jan 10, 2020
Merged

Support wechat notification #38

merged 2 commits into from
Jan 10, 2020

Conversation

DasyDong
Copy link

In china we use wechat at most, so I add wechat notification

@DasyDong DasyDong marked this pull request as ready for review December 17, 2019 08:53
@DasyDong
Copy link
Author

Hello @egeland and @mumoshu, is it possible to review and merge this pr?

matthope
matthope requested changes Dec 19, 2019
View reviewed changes
Copy link
Collaborator

@matthope matthope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also update the README

@DasyDong
Copy link
Author

DasyDong commented Dec 19, 2019 •
edited
Loading

@matthope Updated, thanks a lot

@DasyDong DasyDong requested a review from matthope December 23, 2019 14:16
@DasyDong
Copy link
Author

@matthope

@matthope Updated, thanks a lot
Hi matthope ,did i miss something？is the pr ready to merge ?

@DasyDong
Copy link
Author

DasyDong commented Jan 7, 2020

/assign egeland

@matthope
Copy link
Collaborator

matthope commented Jan 7, 2020

Heya @DasyDong - Please be aware of the points raised in #36

@DasyDong
Copy link
Author

DasyDong commented Jan 7, 2020

Heya @DasyDong - Please be aware of the points raised in #36

got it ! I am also contributed in AWS node termination handler , seems that notification about more ways may not be merged in the short time , maybe in future

@egeland egeland merged commit 601fec5 into kube-aws:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthope matthope matthope approved these changes

@egeland egeland egeland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DasyDong @matthope @egeland