Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this project still needed? #36

Open
egeland opened this issue Nov 13, 2019 · 3 comments
Open

Is this project still needed? #36

egeland opened this issue Nov 13, 2019 · 3 comments
Assignees

Comments

@egeland
Copy link
Collaborator

egeland commented Nov 13, 2019

Now that AWS has https://github.com/aws/aws-node-termination-handler available, should we start contributing to that?
I like that theirs is in Golang, but we have more features...

@mumoshu
Copy link
Contributor

mumoshu commented Nov 13, 2019

@egeland Hey! Thanks for raising this.

Yeah I was thinking about that as well. But I wasn't sure if AWS folks are willing to accept PRs to add features not directly related to their own services(like hipchat, slack, gmail, etc).

So, my best bet is, at first, filing a feature request to add a webhook for notification, so that aws-node-termination-handler can notify to users' own apps to forward notifications to the communication channels of their choice.

After that, I think this project is safe to be archived.

@benjamin-tucker
Copy link

@iomarcovalente
Copy link

@egeland Hey! Thanks for raising this.

Yeah I was thinking about that as well. But I wasn't sure if AWS folks are willing to accept PRs to add features not directly related to their own services(like hipchat, slack, gmail, etc).

So, my best bet is, at first, filing a feature request to add a webhook for notification, so that aws-node-termination-handler can notify to users' own apps to forward notifications to the communication channels of their choice.

After that, I think this project is safe to be archived.

Hi @mumoshu, quoting your reply since as far as I can see since February 2020 aws-node-termination-handler now supports webhook for notification and a bunch of other features (linking the release when webhooks was introduced https://github.com/aws/aws-node-termination-handler/releases/tag/v1.2.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants