Safer Atomic assignment on ARM #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dering race condition with setting the flag/status of an instruction, #294
kriszyp
changed the title
Ethan-Arrowood
approved these changes
Aug 20, 2024
| // That is, if we are on x64 architecture... | ||
| if (arch === 'x64') { | ||
| writeStatus = uint32[flagPosition]; | ||
| uint32[flagPosition] = flags; |
There was a problem hiding this comment.
To be consistent with Atomics.or this should be a |=, but if uint32 is made up of only 0 s then it makes no difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On ARM processors, use a safer Atomic assignment to avoid memory reordering race condition with setting the flag/status of an instruction, #294