Fix incorrect labels when using encode_sets=TRUE

krassowski · Apr 3, 2021 · cb9c515 · cb9c515
1 parent e843a8c
commit cb9c515
Show file tree

Hide file tree

Showing 5 changed files with 230 additions and 6 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,6 +1,9 @@
 # Version 1.2.0
 
-Unreleased
+2021-04-03
+
+Bux fixes:
+- [critical] fixed display order of labels when using encode_sets=TRUE
 
 Major improvements:
 - manually specified intersections will now display empty intersections and non-exclusive intersections correctly #109

diff --git a/R/data.R b/R/data.R
@@ -24,9 +24,9 @@ sanitize_names = function(variables_names) {
 
 encode_names = function(variables_names, avoid) {
     sapply(
-        # using order ensures that alphabetic order is retained in case of equal degrees
+        # using rank ensures that alphabetic order is retained in case of equal degrees
         # and that re-ordering columns in the dataframe will not lead to flickering of the result
-        as.character(order(variables_names)),
+        as.character(rank(variables_names)),
         function (name) {
             while (any(name %in% avoid)) {
                 name = name + 'x'