twitter-archive#93 the session is closed when the channel is

krasa · Apr 18, 2015 · eea933d · eea933d
1 parent 494b6f0
commit eea933d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/main/java/com/cloudhopper/smpp/impl/DefaultSmppSession.java b/src/main/java/com/cloudhopper/smpp/impl/DefaultSmppSession.java
@@ -708,6 +708,7 @@ public void fireChannelClosed() {
             // do nothing -- ignore it
             logger.debug("Unbind/close was requested, ignoring channelClosed event");
         } else {
+            this.state.set(STATE_CLOSED);
             this.sessionHandler.fireChannelUnexpectedlyClosed();
         }
     }

diff --git a/src/test/java/com/cloudhopper/smpp/impl/DefaultSmppSessionTest.java b/src/test/java/com/cloudhopper/smpp/impl/DefaultSmppSessionTest.java
@@ -730,8 +730,9 @@ public void remoteCloseDoesTriggerUnexpectedlyClosedEvent() throws Exception {
         Thread.sleep(500);
 
         Assert.assertEquals(1, sessionHandler.getClosedCount());
-        // DEFAULT handling is that we don't do anything special with this...
-        Assert.assertEquals(true, session.isBound());
+        // the session is closed when the channel is
+        Assert.assertEquals(false, session.isBound());
+        Assert.assertEquals(true, session.isClosed());
 
         // unbind the session now -- this should work okay even though the channel is closed
         session.unbind(100);