Remove uv as a direct dependency
#299
Draft
+69
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinebrl
changed the title
uv as a direct dependencyuv as a direct dependency
antoinebrl
changed the title
uv as a direct dependencyuv as a direct dependency
antoinebrl
changed the title
uv as a direct dependencyuv as a direct dependency
vsiles
approved these changes
Jan 22, 2025
antoinebrl
commented
Jan 22, 2025
Comment on lines
+296
to
+303
| try: | ||
| response = sp.check_output(command, cwd=self.project_directory, env=environ).decode().strip() | ||
| except sp.CalledProcessError as exc: | ||
| if exc.returncode != 1: | ||
| raise | ||
| return None |
There was a problem hiding this comment.
I find that the management of the error and returned value between this block and the parent function get_path is a bit weird. However, this is inspired by the PoetryManagedEnvironment and PdmManagedEnvironment so I went this this approach for consistency.
srstevenson
reviewed
Jan 22, 2025
antoinebrl
force-pushed
the
ab/uv-not-direct-dep
branch
from
b70189b to
4b825c7
Compare
@vsiles , I added a note in the documentation based on your suggestion. Let me know what you think. |
antoinebrl
force-pushed
the
ab/uv-project-manager
branch
3 times, most recently
from
7c5a5d5 to
36017a1
Compare
antoinebrl
force-pushed
the
ab/uv-not-direct-dep
branch
from
4b825c7 to
f6ce255
Compare
antoinebrl
force-pushed
the
ab/uv-not-direct-dep
branch
from
f6ce255 to
9efe461
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mimics how other package managers are operated, that is by assuming they are installed by the user and available via the
PATHenvironment variable. This will also reduce potential mismatches between the different installed versions.Stacked on #297