Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(20732): fix toolbar horizontal scroll padding #994

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Natallia-Harshunova
Copy link
Contributor

@Natallia-Harshunova Natallia-Harshunova commented Feb 26, 2025

https://kontur.fibery.io/Tasks/Task/Toolbar-is-missing-padding-on-horizontal-scroll-20732

Summary by CodeRabbit

  • Style
    • Improved toolbar layout to support horizontal scrolling when content exceeds the available width.

Copy link
Contributor

coderabbitai bot commented Feb 26, 2025

Walkthrough

This change updates the toolbar content styling by adding the CSS property overflow-x: auto; to the .toolbarContent class in the ToolbarContent module. The modification enables horizontal scrolling for toolbar content that exceeds its container's width. No public interfaces or other properties were affected.

Changes

File Change Summary
src/features/toolbar/.../ToolbarContent.module.css Added overflow-x: auto; property to enable horizontal scrolling in the toolbar content.

Poem

I'm a rabbit with hops so light,
Scrolling panels now look just right.
Horizontal space, like a trail so wide,
Smooth and steady, we'll take the ride.
🐇 Cheers to change on this joyful night!
🌟 Keep on scrolling in endless delight!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f2bcaaa and ebc673d.

📒 Files selected for processing (1)
  • src/features/toolbar/components/ToolbarContent/ToolbarContent.module.css (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: deploy
  • GitHub Check: test
🔇 Additional comments (1)
src/features/toolbar/components/ToolbarContent/ToolbarContent.module.css (1)

7-7: Horizontal Scroll Padding Fix Implementation

The addition of overflow-x: auto; to the .toolbarContent class ensures that any toolbar content exceeding the container's width will now properly trigger horizontal scrolling. This change appropriately addresses the reported issue by enabling users to smoothly navigate through overflowed content without compromising the existing flex layout configuration.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Language To Recheck Fuzzy Untranslated Total
ar 3 24 101 128
de 2 24 101 127
es 3 24 101 128
id 2 24 101 127
ko 3 24 101 128
uk 0 7 8 15

Copy link

Bundle size diff

Old size New size Diff
5.19 MB 5.19 MB 14 B (0.00%)

Copy link

Preview environments for this PR:

These previews are automatically updated with each commit.

Note: After a new deployment, it may take a few minutes for the changes to propagate and for caches to update. During this time, you might experience temporary loading issues or see an older version of the app. If the app fails to load, please wait a few minutes and try again.

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.25%. Comparing base (f2bcaaa) to head (ebc673d).

❌ Your project check has failed because the head coverage (1.02%) is below the target coverage (15.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #994   +/-   ##
=======================================
  Coverage   10.25%   10.25%           
=======================================
  Files         696      696           
  Lines       30682    30682           
  Branches     1345     1345           
=======================================
  Hits         3146     3146           
  Misses      26982    26982           
  Partials      554      554           
Components Coverage Δ
UI Components 0.29% <ø> (ø)
Core Logic 18.84% <ø> (ø)
Features 1.02% <ø> (ø)
Utilities 40.97% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov bot commented Feb 26, 2025

Bundle Report

Changes will increase total bundle size by 14 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
konturio/disaster-ninja-fe-esm 5.44MB 14 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: konturio/disaster-ninja-fe-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js -5 bytes 182.77kB -0.0%
assets/index-*.js 2 bytes 5.02kB 0.04%
assets/App-*.js -5 bytes 27.55kB -0.02%
assets/index-*.css 22 bytes 2.61kB 0.85%

Files in assets/index-*.js:

  • ./src/features/toolbar/components/ToolbarContent/ToolbarContent.module.css → Total Size: 584 bytes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants