fix: Update plugin code to support no connection
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candiduslynx
changed the title
plugin code to support no connection
candiduslynx
force-pushed
the
chore/docs
branch
from
ecbdaf8 to
f54fc5b
Compare
koltyakov
reviewed
Oct 31, 2023
| .PHONY: package | ||
| package: | ||
| go run main.go package --docs-dir docs -m @CHANGELOG.md v2.0.0 . |
There was a problem hiding this comment.
I guess it should better be a part of a pipeline (GitHub Action: .github/workflows/release.yaml, as a post release action) which used the git tag as a version instead a hardcoded one.
There was a problem hiding this comment.
Yeah, committed it to the Makefile to make it easier to see & not forget about
|
@koltyakov could you also release a new version with these fixes (maybe retract the old one?) |
|
I republished v2.0.0 with this changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be a good idea to add docs to be distributed through CloudQuery Hub as a follow-up, see #26