[pull] dev from TileDB-Inc:dev #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Fix issue with `unit_readers` not linking in Debug mode. This is due to missing object library dependency on `baseline`. --- TYPE: NO_HISTORY DESC: Fix issue with `unit_readers` not linking in Debug mode.
There was no check for whether an enumeration was loaded before attempting to dump it during a call to ArraySchema::dump. Obviously, dereferencing nullptr is bad so this avoids doing that. The new output now shows the following when a Enumeration isn't loaded: ``` ### Attribute ### - Name: a - Type: INT32 - Nullable: false - Cell val num: 1 - Filters: 0 - Fill value: -2147483648 - Enumeration name: flintstones ### Enumeration ### - Name: flintstones - Loaded: false ``` And after calling `load_all_enumerations`: ``` ### Attribute ### - Name: a - Type: INT32 - Nullable: false - Cell val num: 1 - Filters: 0 - Fill value: -2147483648 - Enumeration name: flintstones ### Enumeration ### - Name: flintstones - Loaded: true - Type: STRING_ASCII - Cell Val Num: 4294967295 - Ordered: false - Element Count: 4 ``` --- TYPE: BUG DESC: Don't segfault in ArraySchema::dump
Update some consolidation tests to run faster after the consolidation setting change. --- TYPE: NO_HISTORY DESC: Make consolidation tests fater.
#4564) Add function `random_label` to utilize PRNG for random string generation. This function is a migration of `random_name` from `test/support/src/helpers` into `common/random`, which has been modified to use the PRNG. Excess declarations of in-test `random_name` have been removed from `tiledb_unit` --- TYPE: IMPROVEMENT DESC: Add function random_label to utilize PRNG for random string generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )