-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MySQLi Database Driver + MySQLi SSL support #94
Conversation
Related to #91 |
@enov normally this would not be allowed because it is a big change. But since you are only adding API and not changing it I am prepared to give a 👍 @zombor and @shadowhand would this be acceptable? |
I understand @rjd22. I'll just leave it here for someone else to merge. |
@@ -28,6 +28,35 @@ | |||
'charset' => 'utf8', | |||
'caching' => FALSE, | |||
), | |||
'alternate_' => array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add this as a commented out example rather than adding a new alternate_
config group?
- We don't want to encourage end-users to actually use the
alternate_
connection to extend our default config - In the unlikely case a user already has an
alternate_
db, we don't want to pollute that config
I know that's different to how the other groups appear, but it is consistent with what we ended up doing in kohana/cache so that the module just ships with example config but it's for end users to copy/paste/configure
their own connections however they want them.
I'd be +1 in adding this to 3.3, if the additional config block gets commented out. |
The additional config block is commented out now. Thanks. |
Add MySQLi Database Driver + MySQLi SSL support
Thanks @acoulton 😄 ! |
Adding MySQLi Database Driver and MySQLi SSL support by cherry-picking related commits that has been merged to 3.4/develop branch.