feat: add is_unique flag for mysql and postgres, partially fixes #20 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
February 23, 2021 01:55
|
MSSQL / SQLite Added |
Sorry if it breaks things 👀
sercanvirlan
commented
Mar 5, 2021
There was a problem hiding this comment.
@rijkvanzanten we need sqlite.db file in order to complete unit tests.
|
My bad, i thought it was a leftover from a seeded test, but the structure is slightly different from the other DB vendors 👍🏻 |
…x-schema-inspector into feat/add_is_unique_flag
|
I tried getting Oracle to run, but for the life of me can't get it to work.. @kibertoad do you have any insight? I tried copying over Knex's setup, but that doesn't seem to run (get some vague |
rijkvanzanten
approved these changes
Mar 5, 2021
|
I'll merge this for now, as everything else is looking good 🙂 We can figure out Oracle testing separately from this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just for mysql and postgres
Additionally help needed for mssql, oracledb, sqlite
Partially fixes #20