Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] Bring back kourier tls runtime tests #15715

Closed
wants to merge 2 commits into from
Closed

[wip] Bring back kourier tls runtime tests #15715

wants to merge 2 commits into from

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Jan 21, 2025

Fixes #

Proposed Changes

Release Note

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 21, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2025
@skonto
Copy link
Contributor Author

skonto commented Jan 21, 2025

I could not reproduce it on the other PR anymore, so let's see.

@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.83%. Comparing base (da5e7fd) to head (8f55911).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/activator/certificate/tls_context.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15715      +/-   ##
==========================================
- Coverage   80.88%   80.83%   -0.05%     
==========================================
  Files         222      222              
  Lines       18063    18064       +1     
==========================================
- Hits        14610    14602       -8     
- Misses       3083     3091       +8     
- Partials      370      371       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor Author

skonto commented Jan 21, 2025

/hold here it is visible.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 21, 2025
View reviewed changes
pkg/activator/certificate/tls_context.go
@@ -50,6 +50,7 @@
san := certificates.DataPlaneUserSAN(revID.Namespace)

tlsConf.VerifyConnection = verifySAN(san)
tlsConf.InsecureSkipVerify = true

Check failure

Code scanning / CodeQL

Disabled TLS certificate check High

InsecureSkipVerify should not be used in production code.
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 21, 2025
View reviewed changes
pkg/activator/certificate/tls_context.go
@@ -50,6 +50,7 @@
san := certificates.DataPlaneUserSAN(revID.Namespace)

tlsConf.VerifyConnection = verifySAN(san)
tlsConf.InsecureSkipVerify = true

Check failure

Code scanning / CodeQL

Disabled TLS certificate check

InsecureSkipVerify should not be used in production code.
@skonto skonto closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso Awaiting requested review from dprotaso

@izabelacg izabelacg Awaiting requested review from izabelacg

@psschwei psschwei Awaiting requested review from psschwei

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skonto