Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly shutdown tracer when the work is done #13226

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Aug 17, 2022

This is a follow-up on knative/pkg#2566

Proposed Changes

  • The shutdown function will flush any buffered tracing Spans

Release Note


@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/API API objects and controllers area/autoscale area/networking labels Aug 17, 2022
@mgencur mgencur changed the title Proper shutdown tracer when the work is done Properly shutdown tracer when the work is done Aug 17, 2022
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #13226 (1fa6a44) into main (dbd3fc3) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #13226      +/-   ##
==========================================
- Coverage   86.67%   86.60%   -0.07%     
==========================================
  Files         196      196              
  Lines       14493    14495       +2     
==========================================
- Hits        12562    12554       -8     
- Misses       1634     1642       +8     
- Partials      297      299       +2     
Impacted Files Coverage Δ
cmd/activator/main.go 0.00% <0.00%> (ø)
pkg/queue/sharedmain/main.go 0.63% <0.00%> (-0.01%) ⬇️
pkg/reconciler/revision/background.go 90.90% <0.00%> (-1.82%) ⬇️
pkg/reconciler/configuration/configuration.go 83.67% <0.00%> (-1.54%) ⬇️
pkg/activator/net/revision_backends.go 92.19% <0.00%> (-0.58%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2022
@knative-prow
Copy link

knative-prow bot commented Aug 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2022
@knative-prow knative-prow bot merged commit d89869e into knative:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/networking lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants