Skip to content

Commit

Permalink
Allow to skip non-alpha/beta test (#527)
Browse files Browse the repository at this point in the history
The `--skip-tests` flag was introduced to skip alpha or beta tests
before and it does not allow to skip stable test.

But now, to support gateway-api, we need to skip some tests as some
funtions are not supported even by the upstream.
  • Loading branch information
nak3 authored Oct 12, 2021
1 parent d5e4386 commit c6e5f78
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions test/conformance/ingress/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,16 @@ var alphaTests = map[string]func(t *testing.T){
//
// Depending on the options it may test alpha and beta features
func RunConformance(t *testing.T) {
skipTests := skipTests()

for name, test := range stableTests {
if _, ok := skipTests[name]; ok {
t.Run(name, skipFunc)
continue
}
t.Run(name, test)
}

skipTests := skipTests()

// TODO(dprotaso) we'll need something more robust
// in the long term that lets downstream
// implementations to better select which tests
Expand Down

0 comments on commit c6e5f78

Please sign in to comment.