This repository has been archived by the owner on Jan 9, 2025. It is now read-only.
fix: overflow check memory operations charge gas #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enitrat
reviewed
Sep 4, 2024
obatirou
force-pushed
the
mcopy-gas-calculation-overflow
branch
from
01a23d1 to
2b740ec
Compare
obatirou
force-pushed
the
mcopy-gas-calculation-overflow
branch
from
f87aa24 to
a6bc68d
Compare
obatirou
force-pushed
the
mcopy-gas-calculation-overflow
branch
from
a6bc68d to
a0e0c09
Compare
ClementWalter
previously approved these changes
Sep 4, 2024
Co-authored-by: Clément Walter <[email protected]>
ClementWalter
approved these changes
Sep 4, 2024
matthieuauger
pushed a commit
to matthieuauger/kakarot
that referenced
this pull request
Nov 9, 2024
* add clap * fix hive chain * add clap to hive genesis * and now we pray * add asdf and pray * missing \ * fix nonce issue in hive genesis * add pool configuration update for hive * remove optional on compat * add relayer private key * start the relayer * lint * add null block hash * fix ts * fix isKakarotTransaction * fix toTypedEthTx * fix slicing * missed that * correctly slice * fixes hive test youpie * lint transaction.ts * ignore failing tests * add pool maintenance task * ignore one last test * add clap * fix hive chain * add clap to hive genesis * and now we pray * add asdf and pray * missing \ * fix nonce issue in hive genesis * add pool configuration update for hive * remove optional on compat * add relayer private key * start the relayer * lint * add null block hash * fix ts * fix isKakarotTransaction * fix toTypedEthTx * fix slicing * missed that * correctly slice * fixes hive test youpie * lint transaction.ts * ignore failing tests * add pool maintenance task * ignore one last test * lint * lint * comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves #1372
What is the new behavior?
Overflow checks for memeory operation before charge gas
This change is