Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase dependency ranges #196

Merged
merged 6 commits into from
May 9, 2021
Merged

Increase dependency ranges #196

merged 6 commits into from
May 9, 2021

Conversation

kiudee
Copy link
Owner

@kiudee kiudee commented May 8, 2021

Description

This pull request removes unnecessary dependencies and widens the dependency ranges where possible.

Motivation and Context

Smaller dependency ranges make the library difficult to install, especially for dependencies still on 0.x.

How Has This Been Tested?

All versions were tested locally by pinning each version separately and seeing if all tests pass.

Does this close/impact existing issues?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

kiudee added 6 commits May 7, 2021 13:26
It is used nowhere in the code and thus not needed to be specified.
We used docopt in earlier versions, but not anymore.
joblib is only used in one of the dataset_readers (rcv_dataset_reader.py).
@kiudee kiudee added the dependencies Pull requests that update a dependency file label May 8, 2021
@codecov
Copy link

codecov bot commented May 8, 2021

Codecov Report

Merging #196 (8a356ca) into master (887d8f0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #196   +/-   ##
=======================================
  Coverage   52.09%   52.09%           
=======================================
  Files         103      103           
  Lines        5093     5093           
=======================================
  Hits         2653     2653           
  Misses       2440     2440           

@kiudee kiudee merged commit 6a55b26 into master May 9, 2021
@kiudee kiudee deleted the deps2 branch May 9, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant