Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cleanup to be consistent with other sites 🦭 #92

Merged
merged 6 commits into from
Dec 1, 2023

Conversation

darcywong00
Copy link
Contributor

Relates to keymanapp/keyman.com#403

To facilitate upcoming deployment, this does some cleanup to be consistent with other sites.

  • Rename /_include to /_includes
  • Remove composer scripts (test action handled by build.sh)
  • Add /control_info.php to troubleshoot tier
  • Cleanup .htaccess

@darcywong00 darcywong00 changed the title chore: Cleanup to be consistent with other sites chore: Cleanup to be consistent with other sites 🦭 Nov 28, 2023
@darcywong00 darcywong00 added this to the A17S27 milestone Nov 28, 2023
<?php
require_once __DIR__ . '/../_includes/autoload.php';
use Keyman\Site\Common\KeymanHosts;
// require_once('includes/template.php');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this comment line be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done - I kinda wonder about moving /_control/info.php into the https://github.com/keymanapp/shared-sites repo

Copy link

@rc-swag rc-swag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@darcywong00 darcywong00 merged commit 4d3ed1e into staging Dec 1, 2023
2 checks passed
@darcywong00 darcywong00 deleted the chore-includes branch December 1, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants