fix: use property_exists instead of array_key_exists (continued) #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdurdin
requested changes
Dec 4, 2024
| return array_key_exists($s, $license_map) ? $license_map[$s] : $s; | ||
| return property_exists($license_map, $s) ? $license_map[$s] : $s; |
There was a problem hiding this comment.
This is incorrect -- $license_map is an array not an object
|
I see. for PHP 7.4 we can still use array_key_exists on arrays. The deprecation notice is on checking objects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #513 and replaces the rest of the deprecated references of
array_key_existswithproperty_exists.Involves swapping parameters...