feat: Allow keyboard search to be localized 📡 #500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcywong00
commented
Nov 13, 2024
| 'en' => 'English', // Default | ||
| 'es-ES' => 'Española', | ||
| 'fr-FR' => 'Français' | ||
| ]; |
There was a problem hiding this comment.
Currently not used. Maybe when we settle on UX for specifying UI locale on the site...
darcywong00
commented
Nov 13, 2024
| <?php if($embed == 'none') echo 'autofocus'; ?>> | ||
| <input id="search-f" type="image" src="<?= cdn('img/search-button.png"') ?>" value="Search" onclick="return do_search()"> | ||
| <label id="search-new"><a href='/keyboards<?=$session_query_q?>'>New search</a></label> | ||
| <input id="search-f" type="image" src="<?= cdn('img/search-button.png"') ?>" value="<?= _("Search") ?>" onclick="return do_search()"> |
There was a problem hiding this comment.
The screenshots show the search button still in English -
It's because we're using a static image
https://github.com/keymanapp/keyman.com/blob/master/cdn/dev/img/search-button.png
Maybe the value doesn't even get used...
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/image#value
There was a problem hiding this comment.
I could convert to a label, if someone can provide some CSS-fu styling
<label id="search-f" class="keyboard_search_button" alt="search button" onclick="return do_search()"> <?= _("Search") ?> </label>
|
Pausing on this after 🦆 with @mcdurdin about the PHP plumbing of localization files/configuration |
|
Abandoning this PR in favor of #521 onward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For starting #384 in localizing the keyboard search page.
(Results come back from api.keyman.com and currently not localized)
The Dockerfile image has updates to install an
n_US.UTF-8locale. Rather than installing more locales, we'll stick with one and use textdomain() to specify the localized files.Strings contained in .po files and get compiled into .mo files during the
./build.sh startstep. All the .po files need to the in/_includes/locale/en/LC_MESSAGE/Add
_s()wrapper so we can do formatted strings with_()- the PHP alias togettext()For now, setup the strings on crowdin at
https://crowdin.com/project/keymancom
Usage
For now, the strings can be accessed by adding a parameter e.g.
http://keyman.com.localhost/keyboards/?locale=fr-FR
http://keyman.com.localhost/keyboards?locale=es-ES
