chore: updates SIL logo for keyman.com #463
Conversation
|
From the issue history
Is it possible to have the PHP randomize one of the 5 Logos? |
|
Yes, I can do that. |
|
I was looking into randomizing the logo on about.md page as well but I am not sure if it is possible. I will look into it until I got a definite answer. |
It's possible in theory but probably not worth the effort 😁 |
|
Yes, thank you! 😄 |
There was a problem hiding this comment.
This is looking good -- I haven't done a full review but before I do I think we should make sure that the ImageRandomizer is in the shared repo (@darcywong00 can help with that)
_includes/2020/ImageRandomizer.php
Outdated
| } | ||
| } | ||
|
|
||
| ?> |
There was a problem hiding this comment.
This along with the png's will be removed once keymanapp/shared-sites#21 is approved and merged.
It will affect the use / require_once paths below too.
There was a problem hiding this comment.
It's now merged and available in shared-sites v0.9
If you change this line to v0.9
Line 5 in c47b0ed
and run ./build.sh configure, it should pull in the image randomizer.
There was a problem hiding this comment.
@darcywong00, do I only need to change the version, and keep everything else the same?
There was a problem hiding this comment.
./build.sh configure means you can also remove the ImageRandomizer.php file and all the .png files on this PR.
about/index.md
Outdated
| @@ -14,7 +14,7 @@ Keyboard layouts are distributed through an open catalog to all major desktop an | |||
| ## About SIL Global | |||
|
|
|||
| <!--div style=style='float:left; margin: 0 16px 0 0'--> | |||
|  | |||
|  | |||
There was a problem hiding this comment.
These paths will now point to / _common/assets/... from keymanapp/shared-sites#21
There was a problem hiding this comment.
Hi @darcywong00.
May I keep the current path? The logo from _common/assets/ is big
There was a problem hiding this comment.
There was a problem hiding this comment.
My concern is having multiple copies of the logo making it hard to maintain.
I saw the footer is using width=50%. Maybe we just use HTML in the Markdown
<img id="sil-logo" src="/_common/assets/sil-logos-2024/sil-logo-abbysinica.png" width="50%" alt='SIL' />
Fixes: #460
Before:
After:
logos are at: https://drive.google.com/drive/folders/1oKnQL3DAhQUWnv3tpJeGvbtYY0tDr0zD