feat: add 'prev' and 'next' version navigation to downloads/releases #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcywong00
reviewed
Aug 13, 2024
| exit; | ||
| } | ||
| ?> | ||
|
|
||
| <a class ="button" href='<?=$KeymanHosts->help_keyman_com?>/version-history/all-versions.php#<?=$versionNumber?>'>View version's history</a> |
There was a problem hiding this comment.
On my development, I was at http://keyman.com.localhost/downloads/releases/14.0.209 so the button had this link:
http://help.keyman.com.localhost/version-history/all-versions.php#14-0-209-beta
But it didn't work for me.
Is there another PR I need to bring in for help.keyman.com?
There was a problem hiding this comment.
Yes, I'll do another PR for help.keyman.com.
There was a problem hiding this comment.
Done on keymanapp/help.keyman.com#1479
mcdurdin
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
LGTM, @darcywong00 do you concur? (I haven't tested locally)
|
Yep - will merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #392