Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update testimonials #444

Merged
merged 9 commits into from
Jul 25, 2024
Merged

chore: Update testimonials #444

merged 9 commits into from
Jul 25, 2024

Conversation

darcywong00
Copy link
Contributor

@darcywong00 darcywong00 commented Apr 24, 2024

I was going to just add an entry to the top of the testimonial page.

Changes

  • Add an entry to the top of the testimonial page
  • Converted half (headers and captions) of the page to Markdown.
  • I also had to move a lot of closing </p> tags for the captions to show.
    Note: ll 123-135 were unchanged so that's the pattern I followed.

I tried setting testimonials like

### I would earnestly like to thank you for the best multilingual keyboard, especially for us [#Ethiopians](https://twitter.com/hashtag/Ethiopians?src=hashtag_click) using [#Geez](https://twitter.com/hashtag/Geez?src=hashtag_click) scripts. It’s simply excellent. {.testimonial}

but the text doesn't quite style right

Original

<p class="center">
  <span class="testimonial">I would earnestly like to thank you for the best multilingual keyboard, especially for us <a href="https://twitter.com/hashtag/Ethiopians?src=hashtag_click">#Ethiopians</a> using <a href="https://twitter.com/hashtag/Geez?src=hashtag_click">#Geez</a> scripts. It’s simply excellent.</span>
</p>

@darcywong00 darcywong00 modified the milestones: B17S6, A18S1 Apr 24, 2024
@darcywong00 darcywong00 modified the milestones: A18S1, A18S2 May 11, 2024
@mcdurdin mcdurdin modified the milestones: A18S2, A18S3 May 24, 2024
@darcywong00 darcywong00 marked this pull request as ready for review May 29, 2024 11:05
@darcywong00
Copy link
Contributor Author

Screenshot of how the Markdown renders

image

@mcdurdin mcdurdin modified the milestones: A18S3, A18S4 Jun 7, 2024
@darcywong00 darcywong00 modified the milestones: A18S4, A18S5 Jun 21, 2024
@darcywong00 darcywong00 modified the milestones: A18S5, A18S6 Jul 5, 2024
@darcywong00 darcywong00 modified the milestones: A18S6, A18S7 Jul 19, 2024
@darcywong00 darcywong00 merged commit 0edef21 into master Jul 25, 2024
2 checks passed
@darcywong00 darcywong00 deleted the chore/testimonials-17 branch July 25, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants