-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds "useCurrentBreakpoints" hook #318
Draft
kettanaito
wants to merge
1
commit into
master
Choose a base branch
from
hooks/use-current-breakpoint
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
import React from 'react' | ||
import { useCurrentBreakpoints } from 'atomic-layout' | ||
|
||
const UseCurrentBreakpointsScenario = () => { | ||
const breakpoints = useCurrentBreakpoints() | ||
|
||
return ( | ||
<p> | ||
Current breakpoint:{' '} | ||
<span data-test-id="current-breakpoints">{breakpoints.join()}</span> | ||
</p> | ||
) | ||
} | ||
|
||
export default UseCurrentBreakpointsScenario |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
describe('useCurrentBreakpoints', () => { | ||
before(() => { | ||
cy.loadStory(['hooks'], ['usecurrentbreakpoints']) | ||
}) | ||
|
||
it('Returns the default breakpoint on initial render', () => { | ||
cy.get('[data-test-id="current-breakpoints"]').should('have.text', 'xs') | ||
}) | ||
|
||
it('Returns "sm" breakpoint name on "sm" breakpoint', () => { | ||
cy.setBreakpoint('sm') | ||
cy.get('[data-test-id="current-breakpoints"]').should('have.text', 'sm') | ||
}) | ||
|
||
it('Returns "md" breakpoint name on "md" breakpoint', () => { | ||
cy.setBreakpoint('md') | ||
cy.get('[data-test-id="current-breakpoints"]').should('have.text', 'md') | ||
}) | ||
|
||
it('Returns "lg" breakpoint name on "lg" breakpoint', () => { | ||
cy.setBreakpoint('lg') | ||
cy.get('[data-test-id="current-breakpoints"]').should('have.text', 'lg') | ||
}) | ||
|
||
it('Returns "xl" breakpoint name on "xl" breakpoint', () => { | ||
cy.setBreakpoint('xl') | ||
cy.get('[data-test-id="current-breakpoints"]').should('have.text', 'xl') | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
import { useState } from 'react' | ||
import useViewportChange from './useViewportChange' | ||
import { Layout, createMediaQuery } from '@atomic-layout/core' | ||
|
||
/** | ||
* Returns a list of breakpoints that match the current state of the viewport. | ||
*/ | ||
export default function useCurrentBreakpoints(): string[] { | ||
const [currentBreakpoints, setCurrentBreakpoints] = useState<string[]>([ | ||
Layout.defaultBreakpointName, | ||
]) | ||
|
||
useViewportChange(() => { | ||
const matchingBreakpoints = Object.keys(Layout.breakpoints).filter( | ||
(breakpointName) => { | ||
const mediaQueryObject = Layout.breakpoints[breakpointName] | ||
/** | ||
* @fixme Move the media query composition and matching logic | ||
* into the `Layout` class. | ||
* @reason It's expensive and redundant to compose strings from | ||
* breakpoints on each viewport change. Breakpoints never change | ||
* on runtime. | ||
*/ | ||
const mediaQuery = createMediaQuery(mediaQueryObject, 'only') | ||
return matchMedia(mediaQuery).matches | ||
}, | ||
) | ||
|
||
setCurrentBreakpoints(matchingBreakpoints) | ||
}) | ||
|
||
return currentBreakpoints | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Returning a list of breakpoint names, because it's possible for multiple breakpoints to match a single state of the viewport:
On a viewport with the width of
500px
bothportrait
andmobile
breakpoints would match.