feat: add linter pipeline for go-grpc app #127
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vibhor Phalke <[email protected]>
|
Hey @khareyash05 , I believe this solves the issue. Also there are lint issues in most sample applications. If you want I can resolve them. |
Comment on lines
47
to
51
| - uses: actions/setup-go@v4 | ||
| with: | ||
| go-version: '1.21' | ||
| go-version: "1.21" | ||
| cache: false | ||
| - name: golangci-lint |
There was a problem hiding this comment.
any reason for doing this ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
Add linter pipeline for go-grpc app
Description:
This PR adds a linter pipeline for the new Go gRPC API to the
samples-gorepository.Issue it solves:
Closes #2511
Changes:
Testing: