Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@import rules with minified CSS that contains other 'url' rules will fail to parse @import's url #69

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jesstelford
Copy link

Examples include:

@import url("min-import-url-quoted-double.css");.minified{background:url("css/nested/test.png");}

/* Which will incorrectly match the URL of the css file as: */
min-import-url-quoted-double.css");.minified{background:url("css/nested/test.png
@import "min-import-quoted-double.css";.minified{background:url("css/nested/test.png");}

/* Which will incorrectly match the URL of the css file as: */
min-import-quoted-double.css";.minified{background:url("css/nested/test.png

This fix updates the @import regex to fix this issue.

Note: See the tests/master/index.html for the unit tests, which have only been tested in IE8!

@corysimmons
Copy link

@keithclark disappeared so I'm going to try and maintain this project at https://github.com/corysimmons/selectivizr2

Would you please reopen/rebase your PR over there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants