Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Server side filtering for alerts #3236

Open
wants to merge 45 commits into
base: main
Choose a base branch
from

Conversation

skynetigor
Copy link
Contributor

@skynetigor skynetigor commented Jan 30, 2025

Closes #3073

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

- Modified `alerts.py` to include server-side filtering logic.
Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2025 0:46am

Copy link

gitguardian bot commented Jan 30, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
15359980 Triggered Generic Private Key 2a9d2f3 keep/providers/clickhouse_provider/clickhouse-secure/certs/server.key View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@skynetigor skynetigor marked this pull request as ready for review January 30, 2025 17:34
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. Feature A new feature labels Jan 30, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 30.37975% with 165 lines in your changes missing coverage. Please review.

Project coverage is 46.36%. Comparing base (5fec2ce) to head (6f4890a).
Report is 75 commits behind head on main.

Files with missing lines Patch % Lines
keep/api/core/alerts.py 28.04% 59 Missing ⚠️
keep/api/routes/alerts.py 32.25% 21 Missing ⚠️
keep/api/core/cel_to_sql/sql_providers/sqlite.py 18.18% 18 Missing ⚠️
keep/api/core/cel_to_sql/sql_providers/mysql.py 16.66% 15 Missing ⚠️
...ep/api/core/cel_to_sql/sql_providers/postgresql.py 16.66% 15 Missing ⚠️
keep/api/routes/facets.py 46.42% 15 Missing ⚠️
keep/api/core/incidents.py 21.42% 11 Missing ⚠️
keep/api/core/cel_to_sql/sql_providers/base.py 22.22% 7 Missing ⚠️
keep/api/routes/incidents.py 60.00% 2 Missing ⚠️
keep/api/core/cel_to_sql/cel_ast_converter.py 50.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3236      +/-   ##
==========================================
+ Coverage   42.60%   46.36%   +3.76%     
==========================================
  Files         182      154      -28     
  Lines       17835    14286    -3549     
==========================================
- Hits         7598     6624     -974     
+ Misses      10237     7662    -2575     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new feature size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: Server-side filtering/sort/search for alerts
1 participant