-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Rebase for k/k 1.32 #98
base: main
Are you sure you want to change the base?
Conversation
Hi @gman0. Thanks for your PR. I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
examples/go.mod
Outdated
|
||
replace acme.corp/pkg => ./pkg | ||
|
||
replace github.com/kcp-dev/client-go => ./rebased_kcp/client-go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependency on client-go, which in turn depends on code-generator. Do we update examples/
in a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking back at my PRs, I updated code-generator first: #90 and then client-go: kcp-dev/client-go#37.
But It's a little messy indeed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(also see #75, btw)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oki, leaving the client-go dependency for now.
03a5bd9
to
3803c22
Compare
I've restructured the commits a bit for hopefully easier review. Also, please see the links in the PR description related to the missing commits that are present in k8s.io/code-generator. Let me know if we should open issues to track progress on them. |
/lgtm waiting for other to review. For now this in the main, so once happy we can cut the release. Maybe worth trying to use the "personal branch" to see if k/k fork will behave before merging? |
LGTM label has been added. Git tree hash: 8e02e39258a6a3d21b87040f1cd8965010cdb20b
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@gman0: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@mjudeikis yes, let's wait for the fork first! Still need to send the PR for client-go, and will continue with k/k fork rebase and if all goes well we can merge them all. |
On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
Needed for go1.23. On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
Needed for client-go v0.32.0. On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
Ran 'make codegen'. On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
New changes are detected. LGTM label has been removed. |
I've missed setting the latest |
Using locally built code-generator. TODO: set this to a real version once kcp-dev/code-generator#98 is merged! On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
Summary
This PR updates k8s to 1.32 and the kcp-dev/apimachinery dependencies.
Some changes that k8s.io/code-generator 0.32.0 offers are not part of this PR, specifically:
These may be added in separate PRs later.
Related issue(s)
Part of kcp-dev/kcp#3209
Release Notes