Skip to content

Commit

Permalink
fix: verify ssm secrets from SSM parameters.
Browse files Browse the repository at this point in the history
It did not fail even if the ssm parameter was missing.
  • Loading branch information
fujiwara committed Jul 12, 2024
1 parent ed17535 commit 4d2d147
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion verify.go
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ func (v *verifier) existsSecretValue(ctx context.Context, from string) error {
} else {
name = from
}
_, err := v.ssm.GetParameters(ctx, &ssm.GetParametersInput{
out, err := v.ssm.GetParameters(ctx, &ssm.GetParametersInput{
Names: []string{name},
WithDecryption: aws.Bool(true),
})
Expand All @@ -138,6 +138,9 @@ func (v *verifier) existsSecretValue(ctx context.Context, from string) error {
return fmt.Errorf("failed to get ssm parameters %s: %w", name, err)
}
}
if len(out.Parameters) == 0 || len(out.InvalidParameters) > 0 {
return fmt.Errorf("ssm parameter %s is not found", name)
}
return nil
}

Expand Down

0 comments on commit 4d2d147

Please sign in to comment.