Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ordinal input #324

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Improve ordinal input #324

merged 1 commit into from
Sep 16, 2024

Conversation

lukebrody
Copy link
Collaborator

  • On mobile devices, show a numerical input for ordinal fields.
  • Navigate when the user blurs the ordinal field. (Solves not being an enter button on mobile, users uses "Done")
  • Select the contents of the ordinal when it is focused (improves UX)
RPReplay_Final1725674582.MP4

@lukebrody lukebrody self-assigned this Sep 7, 2024
@lukebrody lukebrody linked an issue Sep 7, 2024 that may be closed by this pull request
Editing ordinals does not work on iOS because there's no enter button(?) #304
Closed
@lukebrody lukebrody requested a review from kavigupta September 7, 2024 02:07
Base automatically changed from lb/rules-1 to master September 7, 2024 19:36
Improve ordinal on iOS
dcb9dcc 
Select all ordinal field on focus
@lukebrody lukebrody merged commit 7f091f5 into master Sep 16, 2024
14 checks passed
@lukebrody lukebrody deleted the lb/304-ordinal-input branch October 19, 2024 19:27
lukebrody added a commit that referenced this pull request Nov 2, 2024
@lukebrody
Similar improvement to #324
737872c
@lukebrody lukebrody mentioned this pull request Nov 2, 2024
Merged
lukebrody added a commit that referenced this pull request Nov 2, 2024
@lukebrody
Fix stat page number entry on mobile (fixes: #467) (#521)
8feb011 
Similar improvement to #324

Fixes #467
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavigupta kavigupta Awaiting requested review from kavigupta

Assignees

@lukebrody lukebrody

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Editing ordinals does not work on iOS because there's no enter button(?)
1 participant
@lukebrody