Harugi7 #45
Merged
Harugi7 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla6shade
approved these changes
Oct 31, 2024
| justify="flex-start" | ||
| cssOverride={css`margin-top: 5px;`} | ||
| > | ||
| <Controller |
There was a problem hiding this comment.
p2; Switch를 form controller에 넣으신 이유가 있나요?
작성해주신 CalendarSection의 switch는 on/off 여부가 달라질 때 스터디 공개/비공개 여부를 변경하는 데에 사용되는데요, 회원가입, 스터디 생성과 같이 여러 개의 데이터를 하나의 폼에 넣어서 서버에 전달해야할 때와 달리 form에 넣어서 전송하는 것은 불필요해보입니다.
대신 onCheckedChange로 전달되는 콜백을 통해 서버쪽에 공개 여부 변경을 요청하는 것은 어떨까요?
| export default function CalendarSection() { | ||
| const [startDate, setStartDate] = useState<Date | null>(new Date()); | ||
| const [isChecked, setIsChecked] = useState(false); | ||
| const methods = useForm(); |
There was a problem hiding this comment.
p3; 간결함과 가독성을 위해 object destructuring을 사용하는 것은 어떨까요? 물론 지금은 useForm이 불필요하기에 바로 적용하지는 않으셔도 좋습니다.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경점 👍
스터디 내부 페이지 구현하였습니다.
스크린샷 🖼
