Add MIT License

[cugu]

See kaitai-io/kaitai_struct#474

[GreyCat]

Technically and legally, we should reach out to contributors of tests repo and get their approvals to license their work in tests repo using MIT license:

• @GreyCat
• @LogicAndTrick
• @tschoening / @ams-tschoening
• @adrianherrera
• @sealmove
• @koczkatamas
• @jchv
• @cugu
• @nolta
• @modernikarus
• @cherue
• @CWood1
• @mickdekkers
• @markbook2
• @adamiwaniuk
• @13rac1

An ask for everyone mentioned on this list: please provide your approval / disapproval to license your work as per MIT license in this issue?

[jchv]

I approve of this.

[ams-tschoening]

I approve this.

[LogicAndTrick]

Yep, works for me.

[adrianherrera]

This is fine by me.

[nolta]

Sure, approved.

[13rac1]

I approve.

[koczkatamas]

I approved myself :D

[jchv]

Status

Here's where we're at.

• @sealmove: E-mail is available via git log. Contributions
• @modernikarus: E-mail is available via git log. Contributions
• @cherue: ❌ E-mail is not available via git log. • Contributions
• @CWood1: E-mail is available via git log. Contributions
• @mickdekkers: E-mail is available via git log. Contributions
• @markbook2: ❌ E-mail is not available via git log Contributions
• @adamiwaniuk: E-mail is available via git log. Contributions

Here is a table of the currently missing approvals. The word 'significant' here is meant to refer to contributions that are large enough to be considered expressions. (notably, I am not trying to suggest such contributions are not meaningful to the project, just looking at this from a point of view strictly focused on copyright/relicensing.) The bar for originality and non-triviality in terms of copyright differ by jurisdiction, so only the absolute smallest and most trivial contributions will be considered not significant in this case. (Just to be sure, I am not a lawyer, and this does not constitute legal advice.)

Developer	Commits	Added	Removed	Significant?	Have Email
@markbook2	1	8	0	Maybe?[1]	❌

^[1] The sole contribution adds a few declarations to tests. Although relatively small, I believe these changes may clear the bar for copyrightability in some jurisdictions.

What to do

(I have no decision making power, this is just my personal suggestion.)

• Now:

  • Attempt to reach developers via e-mail? This should be coordinated in order to avoid having multiple people do it. I am not posting e-mail addresses here out of respect for privacy.

• In the event not everyone can be reached:

  • Undo commits from developers that we are unable to get consent from.
  • Apply license change.
  • Possibly rewrite changes from scratch based on their intended effects, or simply continue to try to get consent from original authors to reapply later.

[mickdekkers]

Hi there, I just noticed this ping 🙂

I approve 👍

[cugu]

I'll send out some mails.

[cugu]

@adamiwaniuk's email account does not exist any more.

[sealmove]

I approve.

[modernikarus]

I approve.

[cherue]

I approve and I'd like to add that all my contributions to any of the kaitai-io organization repositories are licensed as CC0.

[adamiwaniuk]

I approve.

[CWood1]

I approve of the change

[GreyCat]

Hurray! Looks like we only miss consent of @markbook2. I'll try to reach out to them.

[cherue]

Looking at @markbook2's commit there are two types of changes:

1. Two tests are marked as skipped, this can only be done one way so it can be copied
2. Two tests are marked as "not risky"

The two tests are "risky" because they do not have any assertions, see PHPUnit docs. PHPUnit calls tests like these "useless" but they are not in this case. What is being tested is that the generated PHP is syntactically correct and that it parses some data file without throwing errors. Instead of marking individual tests as "not risky" it is possible to tell PHPUnit that this type of test is ok by passing the --dont-report-useless-tests command line option in run-php.

So, if the decision was made to revert that commit the reimplementation could be:

• Add $this->markTestSkipped(); to kaitai_struct_tests/spec/php/Debug0Test.php and kaitai_struct_tests/spec/php/DebugEnumNameTest.php
• Add --dont-report-useless-tests to kaitai_struct_tests/run-php

[GreyCat]

@markbook2: you seem to be busy these days, but any chance you can sign this off, so we can move forward with adding the license?

[GreyCat]

@cherue @cugu Phew, looks like we're now in full agreement and ready to apply the license. Thanks for this tremendous job, everyone!