Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize, TypeScript support, add tests #29

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Theaninova
Copy link

This PR adds the following

  • Rewrite in TypeScript, the JS version was used as the base but I've done tons of code splitting and rewriting to make the code base more readable
  • Test coverage for the public API
  • Bundling
    • ESM version
    • CJS version
    • Browser bundle with & without Pako

This is meant to enhance kaitai-io/kaitai_struct_compiler#249

@danaragao
Copy link

This is very useful. Any chance that this could be evaluated and merged @generalmimon ?

@cleudojunior
Copy link

Something like this would be amazing. @generalmimon

@generalmimon
Copy link
Member

@cleudojunior:

Something like this would be amazing.

Why? I actually consider this PR unnecessary at this point, because I've already merged #25, so the runtime library is already ported to TypeScript. As far as I can tell, this PR does the same but also adds quite a bit of seemingly unnecessary complexity and the resulting code structure significantly deviates from the structure used in other runtime libraries, which would complicate future maintenance.

So unless you point out to me what is useful about this PR, I'm in favor of closing it.

@cleudojunior
Copy link

@cleudojunior:

Something like this would be amazing.

Why? I actually consider this PR unnecessary at this point, because I've already merged #25, so the runtime library is already ported to TypeScript. As far as I can tell, this PR does the same but also adds quite a bit of seemingly unnecessary complexity and the resulting code structure significantly deviates from the structure used in other runtime libraries, which would complicate future maintenance.

So unless you point out to me what is useful about this PR, I'm in favor of closing it.

That's great, I hadn't seen that that was already added. That was an old need in a system that I work on. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants