-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize, TypeScript support, add tests #29
base: master
Are you sure you want to change the base?
Conversation
This is very useful. Any chance that this could be evaluated and merged @generalmimon ? |
Something like this would be amazing. @generalmimon |
Why? I actually consider this PR unnecessary at this point, because I've already merged #25, so the runtime library is already ported to TypeScript. As far as I can tell, this PR does the same but also adds quite a bit of seemingly unnecessary complexity and the resulting code structure significantly deviates from the structure used in other runtime libraries, which would complicate future maintenance. So unless you point out to me what is useful about this PR, I'm in favor of closing it. |
That's great, I hadn't seen that that was already added. That was an old need in a system that I work on. Thank you so much! |
This PR adds the following
This is meant to enhance kaitai-io/kaitai_struct_compiler#249